Use env var for setting limit and parameterLimit to express's urlenconder #1106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| port = process.env.EXPRESS_PORT or process.env.PORT or 8080 | ||
| address = process.env.EXPRESS_BIND_ADDRESS or process.env.BIND_ADDRESS or '0.0.0.0' | ||
| limit = process.env.EXPRESS_LIMIT or '100kb' | ||
| paramLimit = process.env.EXPRESS_PARAMETER_LIMIT or 1000 |
There was a problem hiding this comment.
Does this have to be run through parseInt?
There was a problem hiding this comment.
I think you are right. If the env EXPRESS_PARAMETER_LIMIT is not a number, NaN or undefined will return just NaN and that or 1000 will give us 1000. Good catch! 👍
| @@ -427,7 +429,7 @@ class Robot | |||
| app.use express.query() | |||
|
|
|||
| app.use express.json() | |||
| app.use express.urlencoded() | |||
| app.use express.urlencoded({limit: limit, parameterLimit: paramLimit}) | |||
There was a problem hiding this comment.
☕ism, but you don't need {} here.
|
I'm okay adding this, but would you mind updating the documentation to talk about these new environment variables? https://github.com/github/hubot/blob/master/docs/scripting.md#http-listener makes sense. |
|
Sound good! |
|
UPDATED 💥 |
bkeepers
approved these changes
May 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For avoiding
413 Request Entity too largein some responses.fixes #1105