Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(travis): drop Node 4, add Node 10 #1454

Merged
merged 1 commit into from
Aug 2, 2018

Conversation

mistydemeo
Copy link
Contributor

As discussed in #1453 (comment), Node 4 has been EOLed and the build isn't currently succeeding on it. This drops Node 4 from the Travis builds and adds Node 10 instead.

Copy link
Member

@technicalpickles technicalpickles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering if there's any consideration to be made for this in terms of next vs latest. Considering 3.0 never made it to latest, I think it's okay if we keep going the node upgrade ladder.

@technicalpickles technicalpickles merged commit 928aff7 into hubotio:master Aug 2, 2018
@mistydemeo mistydemeo deleted the travis_drop_node_4 branch August 2, 2018 19:04
@hubotbot
Copy link

hubotbot commented Aug 3, 2018

🎉 This PR is included in version 3.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants