Persist shell adapter history between invocations of hubot #800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o, don't use maxDiskLength because it's not settable for readline-history
|
Also worth noting I used |
…r writing out to stdout
|
Added this to the list of improvements:
|
setupExpress() assigns @pingIntervalId but then it is being reset to null right after.
Sometimes when copying and pasting hubot commands, one might unintentionally introduce whitespace before the Hubot's name. This commit allows the robot to respond even if the name is prefixed by an arbitrary amount of whitespace.
converted lingering reference to bender to myhubot
Also changes the type of the user.id property, this should be an integer to match campfire.
…BOT_SHELL_USER_ID
technicalpickles
added a commit
to hubotio/generator-hubot
that referenced
this pull request
Dec 5, 2014
technicalpickles
added a commit
that referenced
this pull request
Dec 5, 2014
Persist shell adapter history between invocations of hubot
This was referenced Dec 19, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shell adapter already uses readline, so it gets some text editing niceties, including a history. It doesn't seem to save or load the history though between hubot runs, which can be super annoying when iterating in development. This PR tries to fix that.
The filename and environment variable are inspired by bash.
Probably should update doc/adapters/shell.md before merging this too.