You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This probably has to do with how browsers are parsing text from dates, for example on chrome
Date.parse('something 1');
returns the same as
Date.parse(1);
Even if you fix this, maybe it would be nice to have a way to override the column type, so we can override the type of data we want on the columns. An idea, replace "type" declaration on setupClickableTH for this:
var type, type_override;
type_override = th.getAttribute('data-sort_type');
if (type_override && sortable.types.hasOwnProperty(type_override)) {
type = sortable.types[type_override];
} else {
type = sortable.getColumnType(table, i);
}
The text was updated successfully, but these errors were encountered:
- better handling of touch events (#23, #18)
- allow type to be overridden with `data-` and allow custom types to be set up via `sortable.setupTypes`, uses cleaner compare fns (#21, #17, #16)
- add `CustomEvent` when sorting finishes (#25)
- amd/commonjs (#10)
- stable sort (#14)
- performance improvements when reversing
thx for the help @zackbloom
Thanks @danielocdh. We elected to go the route of allowing both types to be customized and specified directly by a data- attribute on the th. Hopefully this should solve your issue as well as the many other issues people have had with types. An update to the docs will be coming shortly, but in the meantime, please check out cab1613 for more information. Thanks again!
This probably has to do with how browsers are parsing text from dates, for example on chrome
Date.parse('something 1');
returns the same as
Date.parse(1);
Even if you fix this, maybe it would be nice to have a way to override the column type, so we can override the type of data we want on the columns. An idea, replace "type" declaration on setupClickableTH for this:
The text was updated successfully, but these errors were encountered: