Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vignette #113

Merged
merged 17 commits into from
Jun 17, 2024
Merged

Update vignette #113

merged 17 commits into from
Jun 17, 2024

Conversation

lshandross
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Jun 14, 2024

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.02%. Comparing base (105308f) to head (d334d19).

Current head d334d19 differs from pull request most recent head 3e6ec55

Please upload reports for the commit 3e6ec55 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #113   +/-   ##
=======================================
  Coverage   67.02%   67.02%           
=======================================
  Files           6        6           
  Lines         279      279           
=======================================
  Hits          187      187           
  Misses         92       92           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@eahowerton eahowerton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @lshandross! I added a few minor comments, but otherwise I think it's ready to merge. Thanks for all the work on this one!

@lshandross lshandross merged commit 66b648d into main Jun 17, 2024
8 checks passed
This was linked to issues Jun 17, 2024
@lshandross lshandross deleted the update_vignette branch June 20, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
2 participants