Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vignette #15

Merged
merged 7 commits into from
Oct 19, 2023
Merged

Vignette #15

merged 7 commits into from
Oct 19, 2023

Conversation

elray1
Copy link
Contributor

@elray1 elray1 commented Jun 16, 2023

No description provided.

@elray1 elray1 marked this pull request as draft June 16, 2023 13:58
@nickreich
Copy link
Contributor

Noting that #31 has a potential fix for some/all of the R-CMD-check errors here, as I pushed a small fix based on recent updates to distfromq.

@lshandross lshandross marked this pull request as ready for review October 19, 2023 13:53
@lshandross lshandross merged commit d286fc3 into main Oct 19, 2023
0 of 6 checks passed
@lshandross
Copy link
Contributor

Writing a comment to document why the checks were failing and the eventual solution in case it's useful (also because none of the solutions I found via Google seem to work for me). The checks failed because of the following (rather uninformative) warning:

Warning: Files in the 'vignettes' directory but no files in 'inst/doc':
'hubEnsembles.Rmd'

This warning actually occurred because the vignette was not being built. The fix for this was adding the line "VignetteBuilder: knitr" to the DESCRIPTION file, then adding the packages called in the vignette to the Suggests section of the DESCRIPTION file.

lshandross added a commit that referenced this pull request Feb 16, 2024
@lshandross lshandross deleted the vignette branch June 17, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants