Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple ensemble #4

Merged
merged 25 commits into from
Jun 8, 2023
Merged

Simple ensemble #4

merged 25 commits into from
Jun 8, 2023

Conversation

elray1
Copy link
Contributor

@elray1 elray1 commented Jun 7, 2023

No description provided.

@elray1 elray1 requested a review from annakrystalli June 7, 2023 19:57
@elray1 elray1 closed this Jun 8, 2023
@elray1 elray1 reopened this Jun 8, 2023
@nickreich
Copy link
Contributor

minor suggestion without having looked at the code: to avoid magrittr import, could we just use the base pipe of |>?

@elray1
Copy link
Contributor Author

elray1 commented Jun 8, 2023

We had discussed the question of which pipe to use in the context of hubUtils, and there we decided to go with the magrittr pipe to avoid a requirement that users be on R version 4.*.

@elray1 elray1 marked this pull request as draft June 8, 2023 03:00
@elray1
Copy link
Contributor Author

elray1 commented Jun 8, 2023

Noting that current R CMD CHECK failures are due to undocumented parameters -- but those are the parameters that will be passed on to hubUtils::as_model_output_df, and I'm hoping to do something like @inheritParams (or otherwise borrow documentation) for those once that function is available.

Copy link
Collaborator

@annakrystalli annakrystalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! Just a couple of comments/questions.

Also, regarding R CMD CHECK complaining about missing params, fine to ignore, but if you did want to complete the parameters to fix the warning, I could then transfer them to the hubUtils::as_model_out_df() docs and change the inherit params here when it's time?

R/simple_ensemble.R Outdated Show resolved Hide resolved
R/simple_ensemble.R Outdated Show resolved Hide resolved
R/simple_ensemble.R Show resolved Hide resolved
R/simple_ensemble.R Show resolved Hide resolved
R/simple_ensemble.R Show resolved Hide resolved
R/simple_ensemble.R Outdated Show resolved Hide resolved
Co-authored-by: Anna Krystalli <annakrystalli@googlemail.com>
@elray1 elray1 marked this pull request as ready for review June 8, 2023 16:40
@elray1 elray1 merged commit 1582904 into main Jun 8, 2023
5 checks passed
@elray1 elray1 deleted the simple_ensemble branch June 8, 2023 16:41
lshandross pushed a commit that referenced this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants