Bsweger/update readme remove statementid #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ucket It turns out that the statement_id must be unique, so it errored when we associated a second bucket with the lambda function. That said, statement_id is optional, so this changeset removes it.
🍹
|
bsweger
commented
May 15, 2024
| allow_bucket = aws.lambda_.Permission( | ||
| resource_name=f"{hub_name}-allow", | ||
| statement_id="AllowExecutionFromS3Bucket", |
There was a problem hiding this comment.
Alternately, we can retain the statement_id but make it unique by incorporating the name of the hub
3 tasks
matthewcornell
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provisioning the infrastructure for a second cloud-based hub unearthed a bug in the Pulumi code.
It was using a static value as the statement_id in the lambda function permissions. The statement_id, however, must be unique (which is why the bug didn't surface until we added a second hub).
This PR removes statement_id altogether, since it's an optional attribute (and also updates the hub onboarding piece of the README).
Ilustration of what the PR proposes to remove (note that these names are currently unique because I was testing a fix, but upon further reflection, I don't think having a StatementId provides any value here)