Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nomenclature about type, output_type, and target_type #49

Closed
elray1 opened this issue Jun 5, 2023 · 2 comments
Closed

nomenclature about type, output_type, and target_type #49

elray1 opened this issue Jun 5, 2023 · 2 comments

Comments

@elray1
Copy link
Contributor

elray1 commented Jun 5, 2023

Currently in the hub tasks.json, we have:

  1. model_tasks > output_type, which describes a representation or summary of a probability distribution and lines up with the type column in a model output submission file
  2. model_tasks > target_metadata > target_type, which describes a statistical variable type

Maybe we should have a more consistent naming for the two things in point 1? e.g., might we want to change the column name in submission files to output_type rather than just type?

@annakrystalli
Copy link
Contributor

Happy with this and makes sense to me.

Let me know whether to go ahead and implement .

Main changes required will be to:

  • hubDocs: documentation on model-output data format
  • Example hubs (both test mini-hubs in inst and any full example hubs)

@annakrystalli
Copy link
Contributor

This is complete in hubUtils. Still needs addressing in hubDocs but issue exists: hubverse-org/hubDocs#50.

Closing here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants