Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove manual style checking and linting in favor of style ci service #21

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@ install: composer install --prefer-source --no-interaction
script:
- mkdir -p build/logs
- vendor/bin/phpunit
- vendor/bin/phpcs --standard=PSR2 src/
- vendor/bin/parallel-lint src/

after_script:
- php vendor/bin/coveralls
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ PHP Library for ORCID

[![Build Status](https://travis-ci.org/hubzero/orcid-php.svg?branch=master)](https://travis-ci.org/hubzero/orcid-php)
[![Coverage Status](https://coveralls.io/repos/hubzero/orcid-php/badge.svg?branch=master&service=github)](https://coveralls.io/github/hubzero/orcid-php?branch=master)
[![StyleCI](https://styleci.io/repos/38449188/shield)](https://styleci.io/repos/38449188)

This library was started to support the ORCID OAuth2 authentication workflow. It also supports basic profile access, but is a work in progress. More features are to come as needed by the developer or requested/contributed by other interested parties.

Expand Down
2 changes: 0 additions & 2 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@
},
"require-dev": {
"phpunit/phpunit": "4.*",
"squizlabs/php_codesniffer": "2.*",
"jakub-onderka/php-parallel-lint": "0.9.*",
"satooshi/php-coveralls": "dev-master"
},
"autoload": {
Expand Down
12 changes: 4 additions & 8 deletions tests/Http/CurlTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,7 @@ private function curl()
**/
public function testNewCurlCallsInitialize()
{
$call = function()
{
$call = function() {
$curl = new Curl;
};

Expand All @@ -75,8 +74,7 @@ public function testNewCurlCallsInitialize()
**/
public function testCurlResetCallsClose()
{
$call = function()
{
$call = function() {
$curl = new Curl;
$curl->reset();
};
Expand All @@ -92,8 +90,7 @@ public function testCurlResetCallsClose()
**/
public function testCurlExecutes()
{
$call = function()
{
$call = function() {
$curl = new Curl;
$curl->execute();
};
Expand All @@ -109,8 +106,7 @@ public function testCurlExecutes()
**/
public function testSetOptCallsSetOptWithParameter()
{
$call = function()
{
$call = function() {
$curl = new Curl;
$curl->setOpt(CURLOPT_URL, 'http://hubzero.org');
};
Expand Down
2 changes: 1 addition & 1 deletion tests/ProfileTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -121,4 +121,4 @@ public function testGetName()
{
$this->assertEquals('Test User', $this->profile()->fullName(), 'Failed to fetch full name from profile data');
}
}
}