Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unsafe code #1

Merged
merged 2 commits into from
Nov 26, 2019
Merged

Remove unsafe code #1

merged 2 commits into from
Nov 26, 2019

Commits on Nov 26, 2019

  1. construct::utils: Replace unecessary std::ptr::copy_nonoverlapping 

    When copying from different slices, std::slice::copy_from_slice is always
preferable: it implements bounds-checks, is safe, and also calls into memcpy.
    @nbraud
    nbraud committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    e9cb8ec View commit details
    Browse the repository at this point in the history

  2. construct::sacak::sacak_u32: Replace unnecessary std::ptr::copy 

    slice::copy_within supports safely copying within a given slice,
and is implemented with std::ptr::copy.
    @nbraud
    nbraud committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    416cbb8 View commit details
    Browse the repository at this point in the history