Remove Mjolnir.Attributes and reflective proxy classes

hudl · Apr 5, 2017 · 3fb1215 · 3fb1215
1 parent 88642e9
commit 3fb1215
Show file tree

Hide file tree

Showing 11 changed files with 4 additions and 334 deletions.
diff --git a/Hudl.Mjolnir.Tests/Breaker/FailurePercentageCircuitBreakerTests.cs b/Hudl.Mjolnir.Tests/Breaker/FailurePercentageCircuitBreakerTests.cs
@@ -13,7 +13,7 @@ namespace Hudl.Mjolnir.Tests.Breaker
 {
     public class FailurePercentageCircuitBreakerTests : TestFixture
     {
-        private static readonly GroupKey AnyKey = GroupKey.Named("any"); // TODO random
+        private static readonly GroupKey AnyKey = GroupKey.Named(Rand.String());
 
         /// <summary>
         /// The breaker should be created in a good state (fixed).

diff --git a/Hudl.Mjolnir.Tests/Hudl.Mjolnir.Tests.csproj b/Hudl.Mjolnir.Tests/Hudl.Mjolnir.Tests.csproj
@@ -41,9 +41,6 @@
     <WarningLevel>4</WarningLevel>
   </PropertyGroup>
   <ItemGroup>
-    <Reference Include="Castle.Core">
-      <HintPath>..\packages\Castle.Core.2.5.1\lib\NET35\Castle.Core.dll</HintPath>
-    </Reference>
     <Reference Include="Moq">
       <HintPath>..\packages\Moq.4.1.1309.1617\lib\net40\Moq.dll</HintPath>
     </Reference>
@@ -95,10 +92,6 @@
     <None Include="packages.config" />
   </ItemGroup>
   <ItemGroup>
-    <ProjectReference Include="..\Hudl.Mjolnir.Attributes\Hudl.Mjolnir.Attributes.csproj">
-      <Project>{35789458-34e2-42d2-9fc2-043c56c3d011}</Project>
-      <Name>Hudl.Mjolnir.Attributes</Name>
-    </ProjectReference>
     <ProjectReference Include="..\Hudl.Mjolnir\Hudl.Mjolnir.csproj">
       <Project>{9bd60f73-17fb-404e-83cc-61982b393e01}</Project>
       <Name>Hudl.Mjolnir</Name>

diff --git a/Hudl.Mjolnir.Tests/packages.config b/Hudl.Mjolnir.Tests/packages.config
@@ -1,6 +1,5 @@
 <?xml version="1.0" encoding="utf-8"?>
 <packages>
-  <package id="Castle.Core" version="2.5.1" targetFramework="net45" />
   <package id="Moq" version="4.1.1309.1617" targetFramework="net45" />
   <package id="xunit" version="2.0.0" targetFramework="net45" />
   <package id="xunit.abstractions" version="2.0.0" targetFramework="net45" />

diff --git a/Hudl.Mjolnir.sln b/Hudl.Mjolnir.sln
@@ -1,14 +1,12 @@
 
 Microsoft Visual Studio Solution File, Format Version 12.00
-# Visual Studio 14
-VisualStudioVersion = 14.0.25420.1
+# Visual Studio 15
+VisualStudioVersion = 15.0.26228.12
 MinimumVisualStudioVersion = 10.0.40219.1
 Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Hudl.Mjolnir", "Hudl.Mjolnir\Hudl.Mjolnir.csproj", "{9BD60F73-17FB-404E-83CC-61982B393E01}"
 EndProject
 Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Hudl.Mjolnir.Tests", "Hudl.Mjolnir.Tests\Hudl.Mjolnir.Tests.csproj", "{08CAFFC8-7AF8-4E55-ABA3-6B828D246665}"
 EndProject
-Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Hudl.Mjolnir.Attributes", "Hudl.Mjolnir.Attributes\Hudl.Mjolnir.Attributes.csproj", "{35789458-34E2-42D2-9FC2-043C56C3D011}"
-EndProject
 Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution Items", "{B3E4EDE8-23B4-4DD0-A572-D05A31988C74}"
 	ProjectSection(SolutionItems) = preProject
 		README.md = README.md
@@ -28,10 +26,6 @@ Global
 		{08CAFFC8-7AF8-4E55-ABA3-6B828D246665}.Debug|Any CPU.Build.0 = Debug|Any CPU
 		{08CAFFC8-7AF8-4E55-ABA3-6B828D246665}.Release|Any CPU.ActiveCfg = Release|Any CPU
 		{08CAFFC8-7AF8-4E55-ABA3-6B828D246665}.Release|Any CPU.Build.0 = Release|Any CPU
-		{35789458-34E2-42D2-9FC2-043C56C3D011}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
-		{35789458-34E2-42D2-9FC2-043C56C3D011}.Debug|Any CPU.Build.0 = Debug|Any CPU
-		{35789458-34E2-42D2-9FC2-043C56C3D011}.Release|Any CPU.ActiveCfg = Release|Any CPU
-		{35789458-34E2-42D2-9FC2-043C56C3D011}.Release|Any CPU.Build.0 = Release|Any CPU
 	EndGlobalSection
 	GlobalSection(SolutionProperties) = preSolution
 		HideSolutionNode = FALSE

diff --git a/Hudl.Mjolnir/Command/Attribute/CommandInterceptor.cs b/Hudl.Mjolnir/Command/Attribute/CommandInterceptor.cs
diff --git a/Hudl.Mjolnir/Command/Attribute/InvocationCommand.cs b/Hudl.Mjolnir/Command/Attribute/InvocationCommand.cs
diff --git a/Hudl.Mjolnir/Command/Command.cs b/Hudl.Mjolnir/Command/Command.cs
@@ -10,14 +10,6 @@ namespace Hudl.Mjolnir.Command
     /// </summary>
     public abstract class Command
     {
-        // TODO move this comment somewhere (or delete it)
-
-        /// <summary>
-        /// If this is set to true then all calls wrapped in a Mjolnir command will ignore the default timeout.
-        /// This is likely to be useful when debugging Command decorated methods, however it is not advisable to use in a production environment since it disables 
-        /// some of Mjolnir's key features. 
-        /// </summary>
-
         /// <summary>
         /// Cache of known command names, keyed by Type and group key. Helps
         /// avoid repeatedly generating the same Name for every distinct command

diff --git a/Hudl.Mjolnir/Command/CommandInvoker.cs b/Hudl.Mjolnir/Command/CommandInvoker.cs
@@ -623,7 +623,7 @@ private bool IsEnabled()
         {
             return _config.GetConfig("mjolnir.isEnabled", true);
         }
-
+        
         /// <summary>
         /// If this is set to true then all calls wrapped in a Mjolnir command will ignore the
         /// default timeout. This is likely to be useful when debugging Command-decorated methods,