Integrate chained ConfigurableValues for global defaults #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robhruska
added a commit
that referenced
this pull request
Dec 2, 2014
Integrate chained ConfigurableValues for global defaults
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Using a not-yet-available prerelease version of
Hudl.Config).Fixes #33.
Breaker, metrics, pool, and fallback configuration can have default global values provided via config (instead of the hard-coded literal defaults), which allows greater flexibility to tune the defaults at runtime or in an environment-specific way.
Example (using a circuit breaker config); values are used in this order:
mjolnir.breaker.<breaker-name>.thresholdPercentagemjolnir.breaker.default.thresholdPercentageCommandContext(50).Potential breaking change: Any breakers or pools that had previously been named
defaultwill and received specific configuration values will cause those values to get used over the defaults in the code.