add InstanceId in Instance struct #43
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See #44 for related changes that allow one to tunnel an instance ID through to data center types that implement |
|
@qizha Are you using some other provider then Amazon? We are using InstanceId from |
|
thanks for the response. I am not using Amazon right now. Actually, I am going to use Kubernetes with Eureka. I found the problem when I tried Eureka registry plugin with go-micro(https://github.com/micro/go-plugins/blob/master/registry/eureka/) running in my laptop. |
|
Similar change has been merged with #67 Closing this as Resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
missing the instanceId which lead the service registered without instanceId and can not be retrieved by the instanceId later.