Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes problem where package weight was dropped #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

legutierr
Copy link

When new package instances were being created, the weight value was not being preserved. This repairs the problem.

When new package instances were being created, the weight value was not being preserved.  This repairs the problem.
for dimensions in set(permutations((thispackage[0], thispackage[1], thispackage[2]))):
thispackage = Package(dimensions, nosort=True)
thispackage.weight = weight

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just putting this in the above initialization instead?

thispackage = Package(dimensions, weight=weight, nosort=True)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants