Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About metric compatibility #4

Open
NightFurySL2001 opened this issue Jan 12, 2021 · 11 comments
Open

About metric compatibility #4

NightFurySL2001 opened this issue Jan 12, 2021 · 11 comments

Comments

@NightFurySL2001
Copy link

According to many sources, Caladea was introduced into Croscore fonts of Google Chrome OS as a substitute for Cambria, but the version provided here is not metrically compatible with current Cambria.

https://en.wikipedia.org/wiki/Croscore_fonts#Crosextra_fonts
https://wiki.archlinux.org/index.php/Metric-compatible_fonts

tdf-gerrit pushed a commit to LibreOffice/core that referenced this issue Jan 20, 2023
because of the Caladea problem

There are sadly now two Caladea fonts with different metrics, see:
 https://bugzilla.redhat.com/show_bug.cgi?id=2162532
 huertatipografica/Caladea#4

Change-Id: I7080d16ec8aae2bbe60717aea85b980a33340e9b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145830
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
tdf-gerrit pushed a commit to LibreOffice/core that referenced this issue Jan 22, 2023
because of the Caladea problem

There are sadly now two Caladea fonts with different metrics, see:
 https://bugzilla.redhat.com/show_bug.cgi?id=2162532
 huertatipografica/Caladea#4

Change-Id: I7080d16ec8aae2bbe60717aea85b980a33340e9b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145807
Tested-by: Jenkins
Tested-by: René Engelhard <rene@debian.org>
Reviewed-by: René Engelhard <rene@debian.org>
tdf-gerrit pushed a commit to LibreOffice/core that referenced this issue Jan 23, 2023
because of the Caladea problem

There are sadly now two Caladea fonts with different metrics, see:
 https://bugzilla.redhat.com/show_bug.cgi?id=2162532
 huertatipografica/Caladea#4

Change-Id: I7080d16ec8aae2bbe60717aea85b980a33340e9b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145807
Tested-by: Jenkins
Tested-by: René Engelhard <rene@debian.org>
Reviewed-by: René Engelhard <rene@debian.org>
tdf-gerrit pushed a commit to LibreOffice/core that referenced this issue Jan 25, 2023
because of the Caladea problem

There are sadly now two Caladea fonts with different metrics, see:
 https://bugzilla.redhat.com/show_bug.cgi?id=2162532
 huertatipografica/Caladea#4

Change-Id: I7080d16ec8aae2bbe60717aea85b980a33340e9b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145807
Tested-by: Jenkins
Tested-by: René Engelhard <rene@debian.org>
Reviewed-by: René Engelhard <rene@debian.org>
(cherry picked from commit 7a1eb47)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146087
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
@bkmgit
Copy link

bkmgit commented Feb 7, 2023

The file https://github.com/huertatipografica/Caladea/blob/master/sources/ufo/Caladea-Regular.ufo/fontinfo.plist has metrics that are the same as the fonts available at http://gsdview.appspot.com/chromeos-localmirror/distfiles/crosextrafonts-20130214.tar.gz :
Ascent: 778
Descent: -222
Em Size: 1000
Underline position: -89
Height: 57

but in https://fonts.google.com/download?family=Caladea and at https://github.com/huertatipografica/Caladea/tree/bea9e4996451fb18e0bdb5cbd177c8a263c0343d/fonts/ttf the metrics:
Ascent: 800
Descent: 200
Em Size: 1000
Underline position: -100
Height: 50

are used. A related issue is #3

Perhaps the fonts should be regenerated?

@CaroGiovagnoli
Copy link

@vv-monsalve

@bkmgit
Copy link

bkmgit commented Feb 7, 2023

@CaroGiovagnoli @vv-monsalve Thanks.

@davelab6
Copy link

davelab6 commented Mar 24, 2023

I reviewed this with @vv-monsalve and @NightFurySL2001 you are right, so I've ask Viviana to rebuild the project with the compatible metrics and update it in Google Fonts

@vv-monsalve
Copy link
Contributor

vv-monsalve commented Apr 19, 2023

The original vertical metrics of fonts at commit 095c699 v1.001 UFO sources were:

Metrics Values
typoAscender 778
typoDescender -222
typoLineGap 172
hheaAscender 950
hheaDescender -222
hheaLineGap 0
winAscent 950
winDescent 222

@andrestelex, @CaroGiovagnoli, I'll restore the fonts to those values, taking them as the compatible metrics with the reference font. Please confirm these are the intended values.

@vv-monsalve
Copy link
Contributor

@andrestelex, @CaroGiovagnoli

@fabiangreffrath
Copy link

@vv-monsalve Maybe provide a PR that upstream could just merge?

@ethanc8
Copy link

ethanc8 commented Jun 22, 2024

@vv-monsalve is the metrics-copy branch on your repo the most recent version with correct metrics?

@vv-monsalve
Copy link
Contributor

@ethanc8 I initiated the metrics rollback job in that particular branch. However, due to the recent clarification on the font's expected compatibility with Cambria, changes must be made to both the vertical and horizontal metrics. Unfortunately, I haven't had the chance to address the horizontal metrics yet, so that task is still pending.

@ethanc8
Copy link

ethanc8 commented Jun 25, 2024

@ethanc8 I initiated the metrics rollback job in that particular branch. However, due to the recent clarification on the font's expected compatibility with Cambria, changes must be made to both the vertical and horizontal metrics. Unfortunately, I haven't had the chance to address the horizontal metrics yet, so that task is still pending.

Does this mean that the vertical metrics are correct but the horizontal metrics aren't correct in that branch?

@vv-monsalve
Copy link
Contributor

vv-monsalve commented Jun 25, 2024

After a quick inspection of the current source files, yes, these are the current rolled-back vertical metrics:

Screen Shot 2024-06-25 at 11 16 44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants