Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Parallel alignment of periods issue22 #36

Closed
wants to merge 3 commits into from

Conversation

allanderek
Copy link
Collaborator

Parallel execution of alignment for the first and second halves of matches.
Currently not worrying about matches which may extend into extra-time and therefore may have 4 periods.

… match in parallel. If understand things correctly this current version won't work because it does not force the evaluation of the alignment within the par. However, in the comments I've said what might work, and a link to the documentation if that doesn't work. Overall when I try this we should be able to get it to work.
@allanderek allanderek changed the title A little refactoring of main to allow for parallel execution [WIP] Parallel alignment of periods issue22 [WIP] Dec 28, 2018
@huffyhenry
Copy link
Owner

Could we reconcile this first, by merging or cherry-picking, with the code in https://github.com/huffyhenry/sync.soccer/tree/feature/whole-game? There is a lot of duplication.

@allanderek
Copy link
Collaborator Author

How close are you to merging in 'whole-game'? If you do that I'll happily just manually merge in this branch.

@huffyhenry
Copy link
Owner

I merged feature/whole-game into master now, so feel free to complete this merge.

I suggest that you in fact merge master into this branch first, resolve the conflicts on this branch, and auto-merge into master. Otherwise we risk polluting master like I've just done.

… what we had here which duplicated some of that work. I think it would be good to move more of the scoring stuff out to Scoring.hs
@allanderek allanderek changed the title Parallel alignment of periods issue22 [WIP] Parallel alignment of periods issue22 Jan 3, 2019
@allanderek
Copy link
Collaborator Author

Okay I think this is ready now.

@allanderek
Copy link
Collaborator Author

Oh, note that you had, in an earlier commit, removed the 'timeOnly' option, but set the scoring to always be timeOnly. I've left a comment in the relevant place in the SyncMain.hs module.

@huffyhenry huffyhenry changed the title Parallel alignment of periods issue22 [WIP] Parallel alignment of periods issue22 Jan 5, 2019
@huffyhenry huffyhenry closed this Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants