Bugfix/windows compatible sockets #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Windows build failed, @timothycrosley I know the windows config is still being developed :). |
|
LGTM, Thanks for getting this resolved so quickly! Thanks! ~Timothy |
timothycrosley
added a commit
that referenced
this pull request
Mar 20, 2016
Bugfix/windows compatible sockets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes a solution for reported issue #265. I forgot to add Windows support, these changes make the appropriate checks to fill in the
use.Socketattributes according to the platformhugis being executed on.use.Socketin a Windows environment, previous emergency bugfix does not declareuse.SocketifAF_UNIXis not a valid socket attribute.