Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding style tools to CI #802

Merged
merged 16 commits into from
May 21, 2019
Merged

Adding style tools to CI #802

merged 16 commits into from
May 21, 2019

Conversation

jay-tyler
Copy link
Contributor

Let's see if I broke CI...

@jay-tyler
Copy link
Contributor Author

vulture is going to break, but I'm not 100% sure what to do for the following:

hug/decorators.py:160: unused variable 'req_succeeded' (100% confidence)
hug/decorators.py:182: unused variable 'req_succeeded' (100% confidence)
hug/middleware.py:92: unused variable 'req_succeeded' (100% confidence)
hug/middleware.py:141: unused variable 'req_succeeded' (100% confidence)
hug/middleware.py:179: unused variable 'req_succeeded' (100% confidence)

The req_succeeded arg isn't being passed through, but maybe it's there to

  1. to satisfy an interface?
  2. maintain backwards compatibility?

@timothycrosley
Copy link
Collaborator

This is looking great! Correct: It's there to satisfy Falcon's interface: https://falcon.readthedocs.io/en/stable/api/middleware.html - not sure of the best way to let vulture know about this.

@timothycrosley timothycrosley merged commit 1a620cd into develop May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants