Fixes #103 and the git history mess up of #104 #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ead of cls in definitions, refs #103
Closed
|
Black would like to reformat most of |
|
Yep, but I think it is necessary to keep the same coding style not only in this project but also under organization umbrella. And about |
|
I think it is really quite incredible at how fast it has become adopted by the community. Have you noticed lately that the repo has recently be moved? |
chenjr0719
approved these changes
Jun 12, 2019
|
@ahopkins What is the status of this PR? Do i need to do anything before it can be merged? |
|
@volfpeter Thanks. I missed the approval. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please close PR #104 and merge this instead (fixed git history and merge conflicts).