-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change deprecated ssl option in aiohttp #1155
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're not currently using a new enough version for that argument: https://github.com/channelcat/sanic/blob/master/requirements-dev.txt#L2
@r0fls but |
Ah thanks @hatarist, we could also pin the later version since 3.x should work fine. |
Or we could just merge this, but if the version is actually 2.x it will fail so it seems we should bump the requirements to me |
mmm.... Since the |
@nirgn975 Can you update your branch? |
Codecov Report
@@ Coverage Diff @@
## master #1155 +/- ##
==========================================
+ Coverage 83.39% 83.45% +0.05%
==========================================
Files 17 17
Lines 1704 1704
Branches 322 322
==========================================
+ Hits 1421 1422 +1
Misses 217 217
+ Partials 66 65 -1
Continue to review full report at Codecov.
|
Thanks @nirgn975! |
When will this be published to pypi? |
@uda Should be this week 🍻 |
Change
verify_ssl
tossl
inaiohttp.TCPConnector
, becauseverify_ssl
is now deprecated.