Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GIT-1591 Strict Slashes behavior fix #1594

Conversation

harshanarayana
Copy link
Contributor

@harshanarayana harshanarayana commented May 27, 2019

TODO

  • Add documentation for the behavior change of strict_slashes attribute
  • Add example use cases with all possible combination of strict_slashes attribute
  • Fix linter issues in test and fix warnings for test_client usage

@codecov
Copy link

codecov bot commented May 27, 2019

Codecov Report

Merging #1594 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1594   +/-   ##
======================================
  Coverage    91.3%   91.3%           
======================================
  Files          18      18           
  Lines        1828    1828           
  Branches      351     351           
======================================
  Hits         1669    1669           
  Misses        133     133           
  Partials       26      26

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c151582...dfb3e9d. Read the comment docs.

@ahopkins ahopkins changed the title WIP: GIT-1591 Strict Slashes behavior fix and GIT-1592: add dependency on requests-async WIP: GIT-1591 Strict Slashes behavior fix May 27, 2019
@ahopkins
Copy link
Member

I am amending the title so that it is #1591 only. I think the dependency issue in #1592 is a quicker solve and needs a merge sooner than we will have this one resolved.

See #1595

@harshanarayana
Copy link
Contributor Author

@ahopkins works for me.

@yunstanford
Copy link
Member

What is the progress on this PR ? And are you targeting this on 19.6 ? @harshanarayana

@harshanarayana
Copy link
Contributor Author

@yunstanford Yes. I am going to follow the idea discussed in #1591 and split into two work items. Will fix the propagation of strict_slashes flag across. I will update the PR by end of the day.

Signed-off-by: Harsha Narayana <harsha2k4@gmail.com>
@harshanarayana harshanarayana force-pushed the fix/GIT-1591-Strict_Slashes_App_Level-GIT-1592-Requirements branch from 6df06d7 to b583613 Compare June 3, 2019 19:26
Signed-off-by: Harsha Narayana <harsha2k4@gmail.com>
@harshanarayana harshanarayana changed the title WIP: GIT-1591 Strict Slashes behavior fix GIT-1591 Strict Slashes behavior fix Jun 3, 2019
@harshanarayana
Copy link
Contributor Author

@huge-success/sanic-core-devs I am good with this change from my end. Please take a look at the changes and see if there is any change required.

Signed-off-by: Harsha Narayana <harsha2k4@gmail.com>
@yunstanford yunstanford added this to the 19.6 milestone Jun 6, 2019
@sjsadowski sjsadowski merged commit 13079c6 into sanic-org:master Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants