Forgotten slot

[eric-nieuwland]

Crashes the server at init() time

[codecov]

Codecov Report

Merging #1743 into master will increase coverage by 0.12%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #1743      +/-   ##
=========================================
+ Coverage   92.18%   92.3%   +0.12%     
=========================================
  Files          22      22              
  Lines        2238    2274      +36     
  Branches      419     419              
=========================================
+ Hits         2063    2099      +36     
+ Misses        136     135       -1     
- Partials       39      40       +1

Impacted Files	Coverage Δ
sanic/views.py	100% <0%> (ø)	⬆️
sanic/blueprint_group.py	100% <0%> (ø)	⬆️
sanic/reloader_helpers.py	14.73% <0%> (ø)	⬆️
sanic/response.py	100% <0%> (ø)	⬆️
sanic/testing.py	97.94% <0%> (+0.02%)	⬆️
sanic/request.py	99.63% <0%> (+0.02%)	⬆️
sanic/router.py	95.55% <0%> (+0.06%)	⬆️
sanic/app.py	92.25% <0%> (+0.08%)	⬆️
sanic/worker.py	82.78% <0%> (+0.14%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 075affe...a9c669f. Read the comment docs.

[ahopkins]

Thanks for the addition. In what circumstances are you experiencing a crash? What version? What system details?

[eric-nieuwland]

macOS 10.15 Catalina
Created a fresh virtualenv with Python 3.8.
Existing code for a very basic single worker configuration that worked fine with Python 3.7 and older Sanic.
Now wouldn't get passed

app = Sanic("MyApp")
app.static(...) # for favicon
app.add_route(root, "/") # generates page from a template
app.run(host="0.0.0.0", port=8000, debug=True)

Failed on app.run() with a complaint about non-existing attribute "_body_chunks" when creating a HttpProtocol instance when executing a serve() call in sanic/server.py

[johndiego]

same errors

[ahopkins]

@huge-success/sanic-release-managers

[sunshine2995]

macOS 10.15 Catalina
Created a fresh virtualenv with Python 3.8.
Existing code for a very basic single worker configuration that worked fine with Python 3.7 and older Sanic.
Now wouldn't get passed

app = Sanic("MyApp")
app.static(...) # for favicon
app.add_route(root, "/") # generates page from a template
app.run(host="0.0.0.0", port=8000, debug=True)

Failed on app.run() with a complaint about non-existing attribute "_body_chunks" when creating a HttpProtocol instance when executing a serve() call in sanic/server.py

same error

[rubik]

@ahopkins Who can push the release to PyPI? It's unfortunate that the most recent version is still completely broken.

[ahopkins]

@rubik If @sjsadowski and @yunstanford do not take care of it today, then I will later this evening. With holidays and such I am sure everyone is busy.

In general, it is our practice that only the @huge-success/sanic-release-managers do this. But I can if need be as well.

[sjsadowski]

PyPI release is supposed to be automatically uploaded with the release, trying to identify what's broken in the travis build. We'll get it uploaded as soon as we can.

[ahopkins]

Version 19.12.2 is out with this change in place.

The broken Travis builds seem to be not related to the actual tests failing, but that each job seems to be trying to make the PyPI release. 🤔

[rubik]

@ahopkins Great, thanks!