Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selector control acts flaky.... #5

Open
frohro opened this issue Sep 7, 2019 · 1 comment
Open

Selector control acts flaky.... #5

frohro opened this issue Sep 7, 2019 · 1 comment

Comments

@frohro
Copy link

frohro commented Sep 7, 2019

I've read several reviews complaining about the same problem I have. The issue is either that when you press one of the three selector switches, nothing happens. I have to try over and over again. It seems kind of like it depends on what the VNA is doing. It is possible the selector hardware is flaky, but I suspect the software. I'm kind of wondering if the software not monitoring the switch constantly. Could it be made to trigger an interrupt, so button presses are not missed?

I haven't really looked into the source code yet, but it appears you made the change from touch screen to selector switch, so I thought I'd ask. Any ideas?

Thanks,
Rob

@frohro
Copy link
Author

frohro commented Sep 9, 2019

I polled some users on the groups.io list, and found another chap with two analyzers having the same issue, as well as this gentleman, whose blog review is here.
It appears that the problem is that the switch is polled, not interrupt driven. See ui.c, lines 121 and following. Grepping the code yields interrupts for the ADC, and touch, but not the buttons. There looks to be a pretty nice description of how to handle buttons with EXT I interrupts that fire when a button is pressed in ChibiOS with the STM32 here.

The interesting thing is the this polling is in eddy555's code as well, though he has no switch in his hardware. I thought the switch was added so a non touch device could be used, but maybe not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant