Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: Accelerator.__init__() got an unexpected keyword argument 'logging_dir' #1550

Closed
Yetiowner opened this issue Jun 7, 2023 · 2 comments

Comments

@Yetiowner
Copy link

The latest commit has stopped the logging_dir argument from working.
My code:

accelerator = Accelerator(
        gradient_accumulation_steps=gradient_accumulation_steps,
        mixed_precision=mixed_precision,
        log_with=report_to,
        logging_dir=logging_dir,
        project_config=accelerator_project_config,
    )

Raises the error TypeError: Accelerator.init() got an unexpected keyword argument 'logging_dir'

@sgugger
Copy link
Collaborator

sgugger commented Jun 7, 2023

Yes, this argument has been deprecated for two versions and has just been removed, it's now project_dir.

@muellerzr
Copy link
Collaborator

And honestly we should be raising an error here I think, you should just use the project_configuration object for everything if you're using it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants