Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The youtube videos of the collaborative training blog post are not readable on mobiles #134

Closed
SaulLu opened this issue Aug 3, 2021 · 2 comments · Fixed by #135
Closed
Assignees

Comments

@SaulLu
Copy link
Contributor

SaulLu commented Aug 3, 2021

The issue concerns the blog post "Deep Learning over the Internet: Training Language Models Collaboratively" https://hf.co/blog/collaborative-training.

There are two videos - youtube embeddings - in this blog post that integrate well with the blog post when we read it on a computer but display poorly when on mobile.

On computer, the video is well aligned with the text:
image

On mobile, the video is out of frame:

video_mobile.mp4

This issue was originally spotted by @gary149 in this PR

@mishig25 mishig25 self-assigned this Aug 3, 2021
@mishig25
Copy link
Contributor

mishig25 commented Aug 3, 2021

@SaulLum, please use change you've already made:

<div class="aspect-w-16 aspect-h-9">
<iframe src="https://www.youtube-nocookie.com/embed/zdVsg5zsGdc" frameborder="0" allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture" allowfullscreen></iframe>
</div>

Wrap iframe inside <div class="aspect-w-16 aspect-h-9"> ... /div and remove width height from iframe.
Also, please feel free to update any other blog post with YT embed.
(moon-landing##1003 needs to be merged to take effect)
Please let me know if you have any questions or comments 👍

ytembed.mov

@SaulLu
Copy link
Contributor Author

SaulLu commented Aug 3, 2021

Thank you so much 👍 ! It works like a charm 🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants