Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backfill ignores the existing cache entries for previous config/split names #2767

Closed
severo opened this issue May 2, 2024 · 1 comment · Fixed by #2769
Closed

Backfill ignores the existing cache entries for previous config/split names #2767

severo opened this issue May 2, 2024 · 1 comment · Fixed by #2769
Assignees
@severo
Labels
bug Something isn't working P1 Not as needed as P0, but still important/wanted

Comments

@severo
Copy link
Collaborator

severo commented May 2, 2024

See #2766 (comment)

For https://huggingface.co/datasets/re-align/UnifiedChat, for example, we have entries, including an error with LockedDatasetTimeoutError, for config default. But this config does not exist anymore.

In this case, the backfill process should have deleted all the cache entries for config default.
@severo severo mentioned this issue May 2, 2024
Open
@severo severo added bug Something isn't working P1 Not as needed as P0, but still important/wanted labels May 2, 2024
@severo
Copy link
Collaborator Author

severo commented May 2, 2024

Fixing this should remove the unused cache entries. I don't think it's possible to have an idea of their number before fixing the bug.

@severo severo self-assigned this May 2, 2024
@severo severo mentioned this issue May 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@severo severo

Labels
bug Something isn't working P1 Not as needed as P0, but still important/wanted
Projects
None yet
Milestone
No milestone
1 participant
@severo