New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Audio feature #2324
Create Audio feature #2324
Conversation
@lhoestq note that
|
I think current state of this PR could be included in our next release, as experimental feature, for stress testing it and try to find all potential issues. What do you think? |
Looks great! Ready to try it out on the transformers examples after the release :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome, good job @albertvillanova !
Think we are good to merge here no? :-) |
Create
Audio
feature to handle raw audio files.Some decisions to be further discussed:
soundfile
as the audio library; another interesting library islibrosa
, but this requiressoundfile
(see here). If we require some more advanced functionalities, we could eventually switch the library.pip install datasets[audio]
. For the moment, the typical datasets user uses only text datasets, and there is no need for them for additional package requirements for audio/image if they do not need them.pytest-datadir
, which allow to have (audio) data files for testsWav2Vec2
).Note that to install
soundfile
on Linux, you need to installlibsndfile
using your distribution’s package manager, for examplesudo apt-get install libsndfile1
.Requirements Specification