Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HANDS-ON BUG] boolean is a digital number other than 1 or 0 #532

Closed
nanxusu opened this issue May 23, 2024 · 1 comment
Closed

[HANDS-ON BUG] boolean is a digital number other than 1 or 0 #532

nanxusu opened this issue May 23, 2024 · 1 comment

Comments

@nanxusu
Copy link

nanxusu commented May 23, 2024

Describe the bug

https://colab.research.google.com/github/huggingface/deep-rl-class/blob/master/notebooks/unit1/unit1.ipynb?authuser=1#scrollTo=ZNPG0g_UGCfh

For unit1.ipynb, the final two values of the 8-dimention observation should be: If the left leg contact point has touched the land (boolean) and If the right leg contact point has touched the land (boolean).

However, the env.observation_space.sample() returned [-66.26277 87.800964 4.018273 3.077604 -0.1319175 -2.6315386 0.20755419 0.5502597 ], where the final two values are not boolean.

Material

  • Did you use Google Colab?

If not:

  • Your Operating system (OS)
  • Version of your OS
@simoninithomas
Copy link
Member

Hi, I'm agree with you but the official document seems to say https://gymnasium.farama.org/environments/box2d/lunar_lander/ that it's two boolean, I think the best is to open an issue to https://github.com/Farama-Foundation/Gymnasium

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants