Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support optionally using karras sigmas in the k_diffusion wrapper pipeline #1633

Open
apolinario opened this issue Dec 9, 2022 · 7 comments
Labels

Comments

@apolinario
Copy link
Contributor

Is your feature request related to a problem? Please describe.
K-Diffusion enables users to generate sigmas with k_diffusion.sampling.get_sigmas_karras. diffusers currently do not support using those to generate the sigmas with its k_diffusion wrapper

Describe the solution you'd like
Enable users to optionally generate karras sigmas similarly to how AUTO1111 does it https://github.com/AUTOMATIC1111/stable-diffusion-webui/blob/44c46f0ed395967cd3830dd481a2db759fda5b3b/modules/sd_samplers.py#L453

@apolinario apolinario changed the title Support optionally using Karras Sigmas in the K-Diffusion wrapper pipeline Support optionally using karras sigmas in the k_diffusion wrapper pipeline Dec 9, 2022
@patrickvonplaten patrickvonplaten self-assigned this Dec 13, 2022
@patrickvonplaten
Copy link
Contributor

I will try to allocate some time in the next weeks to look into it (can't promise to get it done soon though). Just wondering: do we have some results/benchmarks to know whether karras sigmas work better ?

@apolinario
Copy link
Contributor Author

apolinario commented Dec 13, 2022

I don't think they necessarily work better.

It just works differently and the community enjoys having the possibility of having this variations for artistic purposes when using tools that support it such as AUTO1111 and any other based on k_diffusion so I think it would be great for diffusers to also enable such variations. But I can't say it works better (some people believe so subjectively)

@github-actions github-actions bot added the stale Issues that haven't received updates label Jan 8, 2023
@patrickvonplaten patrickvonplaten removed the stale Issues that haven't received updates label Jan 12, 2023
@huggingface huggingface deleted a comment from github-actions bot Jan 22, 2023
@patrickvonplaten
Copy link
Contributor

In case one is interested in taking a look? @williamberman @yiyixuxu @pcuenca @patil-suraj

@patrickvonplaten
Copy link
Contributor

Here a solution that should work well: #1887 (comment) . Hope to soon find time to implement it :-)

@github-actions github-actions bot added the stale Issues that haven't received updates label Feb 16, 2023
@patrickvonplaten patrickvonplaten removed the stale Issues that haven't received updates label Feb 16, 2023
@huggingface huggingface deleted a comment from github-actions bot Feb 16, 2023
@ym-ctw
Copy link

ym-ctw commented Mar 13, 2023

这里有一个应该运行良好的解决方案:#1887(评论)。希望尽快找到时间来实施它:-)

Did you add the karras sigmas to diffusers's scheduler? I want to use DPM++ 2M karras but I only find DPMSolver multi-step.

@patrickvonplaten
Copy link
Contributor

Not yet @ym-ctw - we'd be more than happy to review a PR though :-)

@ym-ctw
Copy link

ym-ctw commented Mar 16, 2023

Not yet @ym-ctw - we'd be more than happy to review a PR though :-)

Thanks, I really hope you could add karras especially in DPM++ series soon. Because now much more new model are using 'DPM++ 2M karras' to get much better results than 'eular a' and others schedulers, most of these models are from 'civitai.com.'
Hope you could keep an emphasis on it, Thanks for your effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants