Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ControlNet-XS support #5168

Closed
2 tasks done
scarbain opened this issue Sep 24, 2023 · 10 comments · Fixed by #5827
Closed
2 tasks done

ControlNet-XS support #5168

scarbain opened this issue Sep 24, 2023 · 10 comments · Fixed by #5827

Comments

@scarbain
Copy link

Model/Pipeline/Scheduler description

Hello all,

Are you planning on supporting ControlNet-XS ? It's promising a better architecture with a much lower number of parameters for the same quality of results.

Thanks !

Open source status

  • The model implementation is available
  • The model weights are available (Only relevant if addition is not a scheduler).

Provide useful links for the implementation

Code repository : https://github.com/vislearn/ControlNet-XS

Project page : https://vislearn.github.io/ControlNet-XS/

Weights : https://huggingface.co/CVL-Heidelberg/ControlNet-XS (available for Canny and Depth for both SDXL and SD2.1)

@scarbain
Copy link
Author

I forgot to add the handle of the original author : @Sipirius

@patrickvonplaten
Copy link
Contributor

@williamberman @patil-suraj @yiyixuxu anybody interested in porting the controlnets here?

@UmerHA
Copy link
Contributor

UmerHA commented Sep 26, 2023

@patrickvonplaten If okay for you, I'd be happy to do it!

@patrickvonplaten
Copy link
Contributor

Yeah that would be great !

@ayushtues
Copy link
Contributor

Hey @UmerHA let me know if you want any help on this, happy to collaborate on this!

@UmerHA
Copy link
Contributor

UmerHA commented Oct 3, 2023

@ayushtues sure! I think I'll be done with the main implementation & first pipeline by ~mid next week. Then we can qa & split up the remaining pipelines. How should I contact you?

@UmerHA
Copy link
Contributor

UmerHA commented Oct 20, 2023

To give a quick update: I'm working on it (see https://github.com/UmerHA/diffusers/tree/controlnet-xs) and estimate it will take 1-2 more weeks. But am learning a lot! :)

@UmerHA
Copy link
Contributor

UmerHA commented Nov 6, 2023

Another quick update: I'm making steady progress, but can't estimate well when I'll be done.

I have:

  • Understood the paper
  • Converted the paper artifacts into diffusers artifacts
  • Translated the code into diffusers architecture and made it run

I am now:

  • Debugging why the diffusers version doesn't produce the same output as the paper code. But I'm getting closer and closer :)

I still need to:

  • Do that for the other pipelines (img2img, sd [not sdxl], inpainting)
  • Clean up (test, documentation)

Still learning a lot! And thanks for the opportunity to let me do this!

@UmerHA
Copy link
Contributor

UmerHA commented Nov 16, 2023

I'm getting close to being done :)

CleanShot 2023-11-16 at 17 37 05@2x

See here for a working example

@patrickvonplaten I have opened a draft PR (#5827) and would love feedback!

The SDXL canny versions work.

Still to do:

  • Add other versions of ControlNet-XS: SD canny, SD depth, SDXL depth
  • Add documentation
  • A few other (iiuc) minor things

I think it should be done be mid/end next week.

@UmerHA
Copy link
Contributor

UmerHA commented Nov 28, 2023

PR is now marked ready for review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants