Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decide on single test library to use #19

Closed
TimMikeladze opened this issue Feb 28, 2023 · 5 comments · Fixed by #56
Closed

Decide on single test library to use #19

TimMikeladze opened this issue Feb 28, 2023 · 5 comments · Fixed by #56
Assignees
@pngwn
Labels
tooling

Comments

@TimMikeladze
Copy link
Collaborator

Currently both mocha and jest are in use. It would be great to consolidate the testing approach used across all packages.
@o-az
Copy link
Contributor

o-az commented Mar 4, 2023

consider https://vitest.dev/ for a much better ride

@pngwn
Copy link
Member

pngwn commented Mar 4, 2023

Can recommend vitest, we are using in on gradio with much success (although we don't test as much as we should). It may also help with some of the browser testing mentioned in #18.

Happy to help set this up.

@coyotte508
Copy link
Member

Can recommend vitest, we are using in on gradio with much success (although we don't test as much as we should). It may also help with some of the browser testing mentioned in #18.

Happy to help set this up.

Happy to have your help :D

@pngwn pngwn self-assigned this Mar 4, 2023
@o-az
Copy link
Contributor

o-az commented Mar 7, 2023

@pngwn I'd be more than happy to do the jest -> vitest switch. Need to make sure first: does that work or have you already started that?

@pngwn
Copy link
Member

pngwn commented Mar 7, 2023

Already started, PR soon.

@pngwn pngwn mentioned this issue Mar 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pngwn pngwn

Labels
tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

convert all tests to vitest pngwn/huggingface.js
4 participants
@coyotte508 @TimMikeladze @pngwn @o-az