Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QoL] move the WidgetExample part of model-data.ts to its own file (in the same folder) as it's a bit distinct #393

Closed
julien-c opened this issue Dec 5, 2023 · 3 comments · Fixed by #398
Assignees
Labels
tasks @huggingface/tasks related widgets

Comments

@julien-c
Copy link
Member

julien-c commented Dec 5, 2023

also @coyotte508 is kebab-case a hard requirement in file name? i kinda liked the fact that a filename was the name of the main class or type (maybe too late to change though)

@coyotte508
Copy link
Member

also @coyotte508 is kebab-case a hard requirement in file name? i kinda liked the fact that a filename was the name of the main class or type (maybe too late to change though)

That's what I did during the migration for consistency / harmony with the rest of the files in the repo (only HfInfernece.ts breaks that rule) but up to @osanseviero @merveenoyan I guess if they want to change it.

In this case there are multiple types (WidgetExample but also WidgetExampleOutputLabels and so forth) so I don't think it's a problem to keep kebab case for a file with plenty of different definitions inside

@coyotte508
Copy link
Member

also cc @mishig25 who had comments about the widgets-example file placement (mayyyybe we could find a way to put it back in @huggingface/widgets with local dev imports)

@coyotte508 coyotte508 added widgets tasks @huggingface/tasks related labels Dec 5, 2023
@julien-c
Copy link
Member Author

julien-c commented Dec 5, 2023

ok

the first part of the issue remains valid (move the WidgetExample part of model-data.ts to its own file (in the same folder))

@coyotte508 coyotte508 linked a pull request Dec 6, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tasks @huggingface/tasks related widgets
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants