Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Atari surrond is missing from dataset #78

Closed
qgallouedec opened this issue Jun 9, 2023 · 3 comments
Closed

Atari surrond is missing from dataset #78

qgallouedec opened this issue Jun 9, 2023 · 3 comments
Assignees
@edbeeching
Labels
dataset Related to dataset

Comments

@qgallouedec
Copy link
Member

See https://huggingface.co/datasets/gia-project/gia-dataset/discussions/25
@qgallouedec qgallouedec added the dataset Related to dataset label Jun 9, 2023
@qgallouedec qgallouedec mentioned this issue Jun 14, 2023
Closed
@edbeeching
Copy link
Collaborator

I trained a policy on this using envpool. But by default sample-factory's push to hub script uses gymnasium. Surround appears to be missing from gymnasium and gym. I raised an issue.

@qgallouedec
Copy link
Member Author

qgallouedec commented Jul 9, 2023 •
edited
Loading

Can you easily switch to v5?

It it supposed to be equivalent to gymnasium.make("ALE/Amidar-v5", frameskip=1, repeat_action_probability=0.0)

EDIT: add repeat_action_probability=0.0

@edbeeching
Copy link
Collaborator

Fixed by using envpool: https://huggingface.co/datasets/gia-project/gia-dataset/tree/main/data/atari/surround
Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edbeeching edbeeching

Labels
dataset Related to dataset
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@edbeeching @qgallouedec