Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to move to pip release from using old downloaded model? #153

Closed
swartchris8 opened this issue Apr 21, 2019 · 7 comments
Closed

How to move to pip release from using old downloaded model? #153

swartchris8 opened this issue Apr 21, 2019 · 7 comments
Labels

Comments

@swartchris8
Copy link

So I am looking for a way to pip install neuralcoref with spacy 2.0.x

Currently I am using the old 3.0.0 coref lg pretrained spacy model https://github.com/huggingface/neuralcoref-models/releases/download/en_coref_lg-3.0.0/en_coref_lg-3.0.0.tar.gz

I would like to move the pip version of neuralcoref 3.0.0 due to coming across spacy.strings.StringStore size changed, may indicate binary incompatibility issue described in the README.

Following the 4.0.0 README I tried

pip install spacy==2.0.13 
pip install neuralcoref==3.1

Then tried to follow the README neuralcoref initialisation and came across the File "neuralcoref.pyx", line 854, in neuralcoref.neuralcoref.NeuralCoref.get_static File "vectors.pyx", line 116, in spacy.vectors.Vectors.__getitem__ KeyError: 77186543510594498 which is fixed in 4.0.0 according to this issue #98 is there any way to get around this issue while staying on spacy 2.0.x?

It seems to me neuralcoref==3.9 depends on spacy 2.1 so that isn't an option.

@thomwolf
Copy link
Member

thomwolf commented Apr 23, 2019

Hi @swartchris8, we don't plan to keep compatibility with SpaCy 2.0 since its dependency structure was the source of most installation issues that happened over the last months. SpaCy 2.1 is a lot easier to handle.

NeuralCoref 4.0 is also a major update of NeuralCoref 3.0 so you won't be able to mix the model of one with the code of the other.

What happens when you follow the instructions of installation here?

@swartchris8
Copy link
Author

swartchris8 commented Apr 23, 2019

Thanks for the great library first of all. Hopefully I can move to spacy 2.1 soon...

Following the pip install neuralcoref instructions from the current README leads me to this error:

File "neuralcoref.pyx", line 854, in neuralcoref.neuralcoref.NeuralCoref.get_static File "vectors.pyx", line 116, in spacy.vectors.Vectors.__getitem__ KeyError: 77186543510594498

which you seem to have fixed in 4.0.0 based on this issee #98

@thomwolf
Copy link
Member

What os, version of python and spacy are you using?

@swartchris8
Copy link
Author

This was in a python:2.7.16-jessie Docker image with spacy==2.0.13

@thomwolf
Copy link
Member

thomwolf commented Apr 23, 2019

Ok, I'm afraid I can't really help you more since we've dropped compatibility with spacy 2.0...
If you happened to find a work-around you can share it here as it might help others.

Out of curiosity, what is preventing you from moving to SpaCy 2.1?

@swartchris8
Copy link
Author

Long story short we have some dependencies on a 2.0.x and I thought we might need to stay on 2.0 due to some weird Python 2 unicode width requirements.

@stale
Copy link

stale bot commented Jun 27, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jun 27, 2019
@stale stale bot closed this as completed Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants