Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release version number still stay at 0.1 for 2.0 #28

Closed
kfkelvinng opened this issue Apr 19, 2018 · 3 comments
Closed

Release version number still stay at 0.1 for 2.0 #28

kfkelvinng opened this issue Apr 19, 2018 · 3 comments

Comments

@kfkelvinng
Copy link

kfkelvinng commented Apr 19, 2018

https://github.com/huggingface/neuralcoref/blob/2.0/setup.py#L4

Also 2.0 tag seems to be quite different and unstable. Going to post some diff

@thomwolf
Copy link
Member

thomwolf commented May 15, 2018

Hi @kfkelvinng, thanks for that, I will update (a new version is coming soon actually, with huge speed up).
Do you have more information on what you mean by "unstable"?

@kfkelvinng
Copy link
Author

kfkelvinng commented May 15, 2018

Probably it has nothing to do with the 2.0 tag. SpaCy 2.0 may have broken the mention detection for magic pebble
Taking the example text from Winograd Challenge When they had eventually calmed down a bit, and had gotten home, Mr. Farley put the magic pebble in an iron safe. Some day they might want to use it, but really for now, what more could they wish for?

[they,
 a bit,
 Mr. Farley,
 Farley,
 the magic,
 an iron safe,
 safe,
 Some day,
 they,
 it,
 really for now, what more,
 what more,
 they]

It works fine on spacy==1.8.2 and en_core_web_sm-1.2.0
[they, a bit, Mr. Farley, Farley, the magic pebble, an iron, Some day, they, it, really for now, they]

@thomwolf
Copy link
Member

We are now on release v3.0 so I am closing this old issue.
Feel free to open it again (or a new one) if you are experiencing some issues with the new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants