Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some typo error in the picture of flash_attention.md #2057

Open
4 tasks
yejunjin opened this issue Jun 12, 2024 · 2 comments
Open
4 tasks

Some typo error in the picture of flash_attention.md #2057

yejunjin opened this issue Jun 12, 2024 · 2 comments
Labels

Comments

@yejunjin
Copy link

System Info

The notation in last Write phase in Flash attention part of the picture, shoule be Write $O_i, l_i, m_i$ instead of $O_i, l_i, v_i$.
image

Information

  • Docker
  • The CLI directly

Tasks

  • An officially supported command
  • My own modifications

Reproduction

No Need

Expected behavior

Fix flash_attention.md

@LysandreJik
Copy link
Member

Thanks for mentioning it @yejunjin!

@merveenoyan I believe you contributed this image initially, could you confirm? I'm happy to replace the image if so.

Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants