Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the trainer optional when training #527

Closed
n1t0 opened this issue Nov 13, 2020 · 0 comments · Fixed by #519
Closed

Make the trainer optional when training #527

n1t0 opened this issue Nov 13, 2020 · 0 comments · Fixed by #519
Labels
enhancement New feature or request

Comments

@n1t0
Copy link
Member

n1t0 commented Nov 13, 2020

Current state

When training a Tokenizer, we must provide a Trainer:

trainer = BpeTrainer(...)
tokenizer.train(files=[ ... ], trainer=trainer)

This is true even if we instantiate the BpeTrainer without changing any defaults.

Goal

Makes the Trainer optional:

tokenizer.train(files=[ ... ])

How

The Model should be able to return a default trainer:

trainer = model.get_trainer()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant