Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrectly benchmarking #72

Open
JoeyTPChou opened this issue Apr 1, 2023 · 0 comments
Open

Incorrectly benchmarking #72

JoeyTPChou opened this issue Apr 1, 2023 · 0 comments

Comments

@JoeyTPChou
Copy link

All 3 scripts under bloom-inference-scripts incorrectly benchmark the t_generate_span time. The t_generate_span is got from the first generate() call at here https://github.com/huggingface/transformers-bloom-inference/blob/main/bloom-inference-scripts/bloom-ds-inference.py#L257 instead of in the benchmark cycle.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JoeyTPChou