Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable_dropout not used in KTOTrainer #1508

Closed
zwhe99 opened this issue Apr 5, 2024 · 1 comment
Closed

disable_dropout not used in KTOTrainer #1508

zwhe99 opened this issue Apr 5, 2024 · 1 comment
Labels

Comments

@zwhe99
Copy link

zwhe99 commented Apr 5, 2024

When I looked in to the code of KTO, I found a disable_dropout arg in the comment.

disable_dropout (`bool`, defaults to `True`):
Whether or not to disable dropouts in `model` and `ref_model`.

It has never been used in the code. Actually, KTO always disables dropout:

# disable dropout in the model and reference model
disable_dropout_in_model(model)
if self.ref_model is not None:
disable_dropout_in_model(self.ref_model)

Is this an expected behavior?

Copy link

github-actions bot commented May 5, 2024

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants