Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misleading warning message #1511

Closed
concrete13377 opened this issue Apr 7, 2024 · 1 comment
Closed

misleading warning message #1511

concrete13377 opened this issue Apr 7, 2024 · 1 comment

Comments

@concrete13377
Copy link

It is more correct to show batch["labels"], instead of batch["input_ids"] since we are looking for response_token_ids[0] in labels not in input_ids. I understand that labels are just shifted input_ids in most cases, but sometimes it can be really really misleading

https://github.com/huggingface/trl/blob/9a28b3fd0505aa38798f0122ab0ff3bb795384dd/trl/trainer/utils.py#L170C77-L170C86

Copy link

github-actions bot commented May 7, 2024

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant