Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test and fix rounding in timezones #42

Merged
merged 5 commits into from Nov 11, 2018
Merged

Test and fix rounding in timezones #42

merged 5 commits into from Nov 11, 2018

Conversation

hughgrigg
Copy link
Owner

@hughgrigg hughgrigg commented Nov 11, 2018 •
edited

  • Add tests to cover various timezones.
  • Fix issue with sub-hour timezone differences where the time is rounded to the nearest UTC hour, and not the nearest local hour.

@hughgrigg hughgrigg self-assigned this Nov 11, 2018
@hughgrigg hughgrigg mentioned this pull request Nov 11, 2018
Closed
@coveralls
Copy link

coveralls commented Nov 11, 2018 •
edited

Pull Request Test Coverage Report for Build 177

  • 28 of 28 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 166: 0.0%
Covered Lines: 469
Relevant Lines: 469
💛 - Coveralls

@hughgrigg hughgrigg merged commit 1e3bff0 into master Nov 11, 2018
@hughgrigg hughgrigg deleted the timezone-test branch November 11, 2018 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@accesslint accesslint[bot] accesslint approved these changes

Assignees

@hughgrigg hughgrigg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hughgrigg @coveralls