adds more tests, switches coverage library to istanbul

Makefile

@@ -1,8 +1,8 @@
 test:
 	./node_modules/.bin/jscoverage lib lib-cov
-	./node_modules/.bin/mocha -R mocha-lcov-reporter | ./node_modules/coveralls/bin/coveralls.js
+	istanbul cover ./node_modules/mocha/bin/_mocha --report lcovonly -- -R spec && cat ./coverage/lcov.info | ./node_modules/coveralls/bin/coveralls.js && rm -rf ./coverage
 
 clean:
-	rm -rf coverage lib-cov node_modules coverage.html
+	rm -rf coverage lib-cov coverage.html
 
 .PHONY: test

lib/search.js

@@ -47,6 +47,10 @@ module.exports = function search(randr) {
       'mood[happy_songs][to]',
       'mood[happy_songs][from'
     ]);
+
+    if (!params.q) {
+      return callback(new Error('Must specify a query'), null);
+    }
 
     var query = randr.network._buildQuery(params);
     var uri = 'search/tracks?' + query;

package.json

@@ -21,6 +21,7 @@
   },
   "devDependencies": {
     "coveralls": "^2.11.2",
+    "istanbul": "^0.3.7",
     "jscoverage": "^0.5.9",
     "mocha": "^2.2.0",
     "mocha-lcov-reporter": "0.0.2"

test/Albums.js

@@ -1,5 +1,4 @@
 var assert = require("assert");
-var app = require('../lib-cov/albums');
 // setup
 var RandR = require("../index");
 var randr = new RandR(process.env.RANDRMUSICAPIACCESSTOKEN);
@@ -39,6 +38,13 @@ describe('Albums', function(){
         }
       );
     });
+    it('should fail when called without a required parameter',function(done){
+      randr.albums.id({},function(err,data){
+          assert(err!=null);
+          done();
+        }
+      );
+    });
   });
   describe('Similar', function(){
     it('should return a list of similar albums when called with a valid id', function(done){
@@ -73,5 +79,12 @@ describe('Albums', function(){
         }
       );
     });
+    it('should fail when called without a required parameter',function(done){
+      randr.albums.similar({},function(err,data){
+          assert(err!=null);
+          done();
+        }
+      );
+    });
   });
 });

test/Artists.js

@@ -1,5 +1,4 @@
 var assert = require("assert");
-var app = require('../lib-cov/artists');
 // setup
 var RandR = require("../index");
 var randr = new RandR(process.env.RANDRMUSICAPIACCESSTOKEN);
@@ -39,6 +38,13 @@ describe('Artists', function(){
         }
       );
     });
+    it('should fail when called without a required parameter',function(done){
+      randr.artists.id({},function(err,data){
+          assert(err!=null);
+          done();
+        }
+      );
+    });
   });
   describe('Similar', function(){
     it('should return a list of similar artists when called with a valid id', function(done){
@@ -73,5 +79,12 @@ describe('Artists', function(){
         }
       );
     });
+    it('should fail when called without a required parameter',function(done){
+      randr.artists.similar({},function(err,data){
+          assert(err!=null);
+          done();
+        }
+      );
+    });
   });
 });

test/Search.js

@@ -1,5 +1,4 @@
 var assert = require("assert");
-var app = require('../lib-cov/search');
 // setup
 var RandR = require("../index");
 var randr = new RandR(process.env.RANDRMUSICAPIACCESSTOKEN);
@@ -20,5 +19,12 @@ describe('Search', function(){
         );
       })
     });
+    it('should fail when called without a required parameter',function(done){
+      randr.search.tracks({},function(err,data){
+          assert(err!=null);
+          done();
+        }
+      );
+    });
   });
 });

test/Tracks.js

@@ -1,5 +1,4 @@
 var assert = require("assert");
-var app = require('../lib-cov/tracks');
 // setup
 var RandR = require("../index");
 var randr = new RandR(process.env.RANDRMUSICAPIACCESSTOKEN);
@@ -39,6 +38,13 @@ describe('Tracks', function(){
         }
       );
     });
+    it('should fail when called without a required parameter',function(done){
+      randr.tracks.id({},function(err,data){
+          assert(err!=null);
+          done();
+        }
+      );
+    });
   });
   describe('Recommendations', function(){
     it('should return a list of recommendations when called with a valid id', function(done){
@@ -73,5 +79,12 @@ describe('Tracks', function(){
         }
       );
     });
+    it('should fail when called without a required parameter',function(done){
+      randr.tracks.recommendations({},function(err,data){
+          assert(err!=null);
+          done();
+        }
+      );
+    });
   });
 });