aptcc: Not all downloads have to be packages #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the mirror method is used in apt 1.6 or newer, a mirror list is downloaded prior to any package, causing PackageKit to crash after casting its item to pkgAcqArchiveSane. pkgAcqArchiveSane is a local workaround to expose some protected stuff in pkgAcqArchive, so we first do a dynamic_cast to pkgAcqArchive which will be nullptr if it is not a pkgAcqArchive and then cast it statically to pkgAcqArchiveSane. Bug-Ubuntu: https://launchpad.net/bugs/1754265
|
LGTM Thanks. |
|
Awesome! I was looking at that crash a few days ago, and it didn't make much sense to me - but this is a perfect explanation! :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the mirror method is used in apt 1.6 or newer, a mirror list is
downloaded prior to any package, causing PackageKit to crash after
casting its item to pkgAcqArchiveSane.
pkgAcqArchiveSane is a local workaround to expose some protected
stuff in pkgAcqArchive, so we first do a dynamic_cast to pkgAcqArchive
which will be nullptr if it is not a pkgAcqArchive and then cast it
statically to pkgAcqArchiveSane.
Bug-Ubuntu: https://launchpad.net/bugs/1754265
CC @ximion