New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port to meson build system #309
Conversation
bc29a5a
to
3fcbba8
Compare
Ninja dist seems to fail now:
Also, aren't meson options supposed to be using |
The meson style itself doesn't recommend anything regarding dashes and underscores |
I was about to say that fwupd uses underscores, but now I see it uses both :/ -- I think there was some pressure for gnome-software to move from - to _, so I think that's probably what we should do here. Sorry! |
I think get the tests fixed on CI, and then we can merge this. Thanks. |
20977a7
to
fe886fd
Compare
@tintou: Are you planning on updating this / addressing the last comments? Two GNOME goals needs it: the gettext port and the Meson port. Would be nice to have that included in next PackageKit release. I could help if you don't have time to spend on this patch set any more. |
Also `backend_name` is registered by meson so using `packaging_backend`
@t-chaik Yeah, feel free to continue the work |
@t-chaik hey! did you have, by any chance, time to update this PR? |
Haven't been able to find some time yet but that's still on my list. I'll try to have a look next week. Would that work for your release or would it be too late? |
@hughsie: Do you mind giving me write access to the |
@t-chaik Could you create a new PR initially? That would unblock showing us the code. |
@t-chaik i think a new PR is best. |
Here: #332. I've pushed some fixes already but haven't look at the test failures yet. Will remove the WIP label once I believe it to be ready. |
I've fixed up a lot of the issues, so lets continue in #365 -- all comments there very welcome, thanks! |
This is a meson port which might help to maintain PackageKit
(follow-up of #307)