Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to meson build system #309

Closed
wants to merge 19 commits into from
Closed

Port to meson build system #309

wants to merge 19 commits into from

Conversation

tintou
Copy link
Collaborator

@tintou tintou commented Jan 25, 2019

This is a meson port which might help to maintain PackageKit
(follow-up of #307)

@hughsie
Copy link
Collaborator

hughsie commented Jan 25, 2019

Ninja dist seems to fail now:

ERROR: ['gtkdoc-mkhtml', '--path=/tmp/tmpoehjxhle/PackageKit-1.1.13/docs/api:/tmp/tmpx1bl9br8/docs/api', 'PackageKit', '../PackageKit-docs.sgml'] failed with status 6
warning: failed to load external entity "../dbus/org.freedesktop.PackageKit.ref.xml"
../PackageKit-docs.sgml:57: element include: XInclude error : could not load ../dbus/org.freedesktop.PackageKit.ref.xml, and no fallback was found
warning: failed to load external entity "../dbus/org.freedesktop.PackageKit.Transaction.ref.xml"
../PackageKit-docs.sgml:58: element include: XInclude error : could not load ../dbus/org.freedesktop.PackageKit.Transaction.ref.xml, and no fallback was found

Also, aren't meson options supposed to be using _ rather than - these days?

@tintou
Copy link
Collaborator Author

tintou commented Jan 25, 2019

The meson style itself doesn't recommend anything regarding dashes and underscores
GNOME Builder uses underscores and Gtk uses dashes 🤷‍♂️
I'm okay with both so feel free to change to whatever you prefer

@hughsie
Copy link
Collaborator

hughsie commented Jan 25, 2019

GNOME Builder uses underscores

I was about to say that fwupd uses underscores, but now I see it uses both :/ -- I think there was some pressure for gnome-software to move from - to _, so I think that's probably what we should do here. Sorry!

contrib/PackageKit.spec.in Outdated Show resolved Hide resolved
@hughsie
Copy link
Collaborator

hughsie commented Feb 15, 2019

I think get the tests fixed on CI, and then we can merge this. Thanks.

tests/ci/Dockerfile-fedora Outdated Show resolved Hide resolved
tests/ci/Dockerfile-fedora Outdated Show resolved Hide resolved
@t-chaik
Copy link

t-chaik commented May 23, 2019

@tintou: Are you planning on updating this / addressing the last comments? Two GNOME goals needs it: the gettext port and the Meson port. Would be nice to have that included in next PackageKit release. I could help if you don't have time to spend on this patch set any more.

@tintou
Copy link
Collaborator Author

tintou commented May 24, 2019

@t-chaik Yeah, feel free to continue the work

@jjardon
Copy link
Contributor

jjardon commented Jul 30, 2019

@t-chaik hey! did you have, by any chance, time to update this PR?

@t-chaik
Copy link

t-chaik commented Jul 31, 2019

Haven't been able to find some time yet but that's still on my list. I'll try to have a look next week. Would that work for your release or would it be too late?

@t-chaik
Copy link

t-chaik commented Aug 7, 2019

@hughsie: Do you mind giving me write access to the wip/tintou/meson branch? I can create a new PR if you prefer, up to you.

@Conan-Kudo
Copy link
Member

@t-chaik Could you create a new PR initially? That would unblock showing us the code.

@hughsie
Copy link
Collaborator

hughsie commented Aug 8, 2019

@t-chaik i think a new PR is best.

@t-chaik
Copy link

t-chaik commented Aug 8, 2019

Here: #332. I've pushed some fixes already but haven't look at the test failures yet. Will remove the WIP label once I believe it to be ready.

@hughsie
Copy link
Collaborator

hughsie commented Jan 9, 2020

I've fixed up a lot of the issues, so lets continue in #365 -- all comments there very welcome, thanks!

@hughsie hughsie closed this Jan 9, 2020
@tintou tintou deleted the wip/tintou/meson branch November 15, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants