Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wip/hughsie/meson #365

Merged
merged 14 commits into from Jan 10, 2020
Merged

Wip/hughsie/meson #365

merged 14 commits into from Jan 10, 2020

Conversation

hughsie
Copy link
Collaborator

@hughsie hughsie commented Jan 9, 2020

No description provided.

@hughsie hughsie self-assigned this Jan 9, 2020
This was referenced Jan 9, 2020
Closed
Closed
Conan-Kudo
Conan-Kudo requested changes Jan 9, 2020
View reviewed changes
meson_options.txt Outdated Show resolved Hide resolved
@ximion
Copy link
Collaborator

ximion commented Jan 9, 2020

-DPK_COMPILATION could probably be set as global argument in the main Meson file, at least for the C language: add_global_arguments('-DPK_COMPILATION', language : 'c')
That will avoid a tiny bit of duplication.

@hughsie
Copy link
Collaborator Author

hughsie commented Jan 9, 2020

DPK_COMPILATION could probably be set as global argument

Good idea, done.

@lgtm-com
Copy link

lgtm-com bot commented Jan 9, 2020

This pull request fixes 8 alerts when merging dd9e635 into c16ae90 - view on LGTM.com

fixed alerts:

  • 3 for Unused local variable
  • 2 for Except block handles 'BaseException'
  • 2 for Variable defined multiple times
  • 1 for 'import *' may pollute namespace

@lgtm-com
Copy link

lgtm-com bot commented Jan 9, 2020

This pull request fixes 8 alerts when merging 9718122 into c16ae90 - view on LGTM.com

fixed alerts:

  • 3 for Unused local variable
  • 2 for Except block handles 'BaseException'
  • 2 for Variable defined multiple times
  • 1 for 'import *' may pollute namespace

@lgtm-com
Copy link

lgtm-com bot commented Jan 9, 2020

This pull request fixes 27 alerts when merging 6fd291b into c16ae90 - view on LGTM.com

fixed alerts:

  • 10 for Unused local variable
  • 6 for Variable defined multiple times
  • 4 for 'import *' may pollute namespace
  • 3 for Except block handles 'BaseException'
  • 2 for Unused import
  • 1 for Testing equality to None
  • 1 for Unreachable code

@lgtm-com
Copy link

lgtm-com bot commented Jan 9, 2020

This pull request fixes 27 alerts when merging eacf702 into c16ae90 - view on LGTM.com

fixed alerts:

  • 10 for Unused local variable
  • 6 for Variable defined multiple times
  • 4 for 'import *' may pollute namespace
  • 3 for Except block handles 'BaseException'
  • 2 for Unused import
  • 1 for Testing equality to None
  • 1 for Unreachable code

Conan-Kudo
Conan-Kudo requested changes Jan 9, 2020
View reviewed changes
backends/aptcc/meson.build
],
cpp_args: [
'-DG_LOG_DOMAIN="PackageKit-APTcc"',
'-DPK_COMPILATION=1',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need this in the nix, slack, and zypp backends too.

@lgtm-com
Copy link

lgtm-com bot commented Jan 9, 2020

This pull request fixes 27 alerts when merging 012a9d1 into c16ae90 - view on LGTM.com

fixed alerts:

  • 10 for Unused local variable
  • 6 for Variable defined multiple times
  • 4 for 'import *' may pollute namespace
  • 3 for Except block handles 'BaseException'
  • 2 for Unused import
  • 1 for Testing equality to None
  • 1 for Unreachable code

Corentin Noël and others added 8 commits January 9, 2020 15:56
@hughsie
Port to the meson build system
7028808 
With much help from Martin Blanchard <tchaik@gmx.com> too, thanks to all.

https://wiki.gnome.org/Initiatives/GnomeGoals/MesonPorting
@hughsie
Remove the GTK2 gtk-module support
8e8a203
@hughsie
trivial: Remove the I_KNOW_THE_PACKAGEKIT_GLIB2_API_IS_SUBJECT_TO_CHA…
c930bfb 
…NGE requirement
@hughsie
pisi: Remove unmaintained backend
9942514 
The pisi package manager is no longer used as Pardus is Debian-based now.
@hughsie
urpmi: Remove unmaintained backend
2eaff62 
Mageia 6 switched to DNF backend exclusively and Mageia 5 is EOL. ROSA also
switched to rpm.org + libdnf.
@hughsie
ports: Remove unmaintained backend
81bba4b 
Even macports doesn't carry it anymore.
@hughsie
yum: Remove unmaintained backend
355d720 
This is only used in RHEL 7 which is not going to get rebased to this brand new
PackageKit branch.
@hughsie
trivial: Always include <config.h>
54e1d1e
@lgtm-com
Copy link

lgtm-com bot commented Jan 9, 2020

This pull request fixes 27 alerts when merging 54e1d1e into c16ae90 - view on LGTM.com

fixed alerts:

  • 10 for Unused local variable
  • 6 for Variable defined multiple times
  • 4 for 'import *' may pollute namespace
  • 3 for Except block handles 'BaseException'
  • 2 for Unused import
  • 1 for Testing equality to None
  • 1 for Unreachable code

@hughsie
Copy link
Collaborator Author

hughsie commented Jan 9, 2020

I'm tempted to merge this tomorrow, and we can work out any problems in master as fixups. Speak now, or forever hold your peace :)

@Conan-Kudo
Copy link
Member

I'd say merge it now, so that this doesn't get more monstrous.

@ximion
Copy link
Collaborator

ximion commented Jan 9, 2020

Merge tomorrow sounds fine :-)

@hughsie hughsie merged commit 1f794bf into master Jan 10, 2020
@hughsie hughsie deleted the wip/hughsie/meson branch January 10, 2020 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Conan-Kudo Conan-Kudo Conan-Kudo requested changes

Assignees

@hughsie hughsie

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hughsie @ximion @Conan-Kudo