Omitting ".desktop" suffix is allowed #146
Comments
|
Whilst I agree that in the spec it says that, a good proportion of the tools that generate and consume AppStream XML will currently break if you omit the .desktop suffix. I was talking to @ximion yesterday about this, and we need more details in the specification to deal with when the application ID does not match the appstream ID. Until we've got it sorted out in the spec, and a good majority of tools don't break, I think including the .desktop in the is a very good idea. |
|
@hughsie The spec is fine and this change has been in production at Debian for almost a year without noticeable breakage - the only thing that is potentially broken is launching such apps in GNOME Software, all other tools using libappstream are fine (since libas had a So, I think this is a safe change, if done right with appropriate fallback code. That being said, I still would like to have an explicit tag in AppStream to specify a way to launch apps (by command, dbus-activation or desktop-id), to get rid of some automagic and to support the case of desktop-app components not having a directly associated launchable .desktop file (or multiple files, for that matter - think of software suites (rare, but they exist)). |
|
Okay, I'm fine with removing the validation warning. I'm not fine removing the validation warning before we talk about XML API on how to launch apps. |
|
Getting the |
|
Right, this depends on that. |
|
It's solved now... ;-) |
Notably, set a minimum version requirement for appstream-util. Prior to 0.7.2, `appstream-util validate` would complain if your application ID did not end in `.desktop`. That requirement was dropped as a result of hughsie/appstream-glib#146; transmission-remote-gtk began taking advantage of the looser checking in dd01b09. Also add an explicit dependency on libappstream-glib-dev, which was previously being pulled in as a transitive dependency.
This is the same bug as ximion/appstream#100.
If the id of a desktop application does not end in ".desktop", appstream-util validate will complain
<id> does not have correct extension for kind. That is incorrect as the specification tells usOmitting the ".desktop" suffix is not an error.
A relevant line: https://github.com/hughsie/appstream-glib/blob/master/libappstream-glib/as-app-validate.c#L1111
The text was updated successfully, but these errors were encountered: