as-self-test fails since 0.8.0

[heftig]

The as-self-test fails since 0.8.0:

<It now also supports<em>em</em><code> and </code><code>code</code> tags.>
Bail out! As:ERROR:../appstream-glib/libappstream-glib/as-self-test.c:2944:as_test_node_xml_func: assertion failed (as_node_get_data (n2) == "It now also supports<em>em</em> and <code>code</code> tags."): ("It now also supports<em>em</em><code> and </code><code>code</code> tags." == "It now also supports<em>em</em> and <code>code</code> tags.")
stderr:
**
As:ERROR:../appstream-glib/libappstream-glib/as-self-test.c:2944:as_test_node_xml_func: assertion failed (as_node_get_data (n2) == "It now also supports<em>em</em> and <code>code</code> tags."): ("It now also supports<em>em</em><code> and </code><code>code</code> tags." == "It now also supports<em>em</em> and <code>code</code> tags.")

Bisection identified f939f14 as the first broken commit.

meson setup + compile log: appstream-glib-0.8.0-1-x86_64-build.log
meson test log: appstream-glib-0.8.0-1-x86_64-check.log

[heftig]

Looking at the test that f939f14 added, I think even if it did pass, the code is broken.

The source markup is:

appstream-glib/libappstream-glib/as-self-test.c

Lines 2868 to 2872 in 2415ed7

	const gchar *valid_em_code = "<description>"
	"<p>"
	"It now also supports <em>em</em> and <code>code</code> tags."
	"</p>"
	"</description>";

And the expected data is:

appstream-glib/libappstream-glib/as-self-test.c

Line 2944 in 2415ed7

g_assert_cmpstr (as_node_get_data (n2), ==, "It now also supports<em>em</em> and <code>code</code> tags.");

The space between supports and <em>em</em> is gone.

[hughsie]

It worked here (and continues to work); can you debug a bit please?

[heftig]

Any idea what could affect this? Some dependency?

[heftig]

The new fields in the AsNodeToXmlHelper struct aren't being initialized.

(Also, they should probably be bitfields for consistency.)

[hughsie]

Can you do a pr please?