as-content-rating: Add as_content_rating_get_rating_ids() #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the set of rating IDs in the AsContentRating to be returned, allowing the caller to iterate over them to check their values, rather than having to hard-code their own list of OARS rating IDs. Includes a basic test. Signed-off-by: Philip Withnall <withnall@endlessm.com>
hughsie
reviewed
Nov 1, 2018
|
One little nit, and then LGTM, thanks. I've given you push access to master, so please just merge when you've fixed it up locally. |
|
Thanks for the fast review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the set of rating IDs in the AsContentRating to be returned,
allowing the caller to iterate over them to check their values, rather
than having to hard-code their own list of OARS rating IDs.
Includes a basic test.
Signed-off-by: Philip Withnall withnall@endlessm.com