Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xb-silo: skip xb_query_to_string() unless error is set #137

Merged
merged 1 commit into from Jul 31, 2023
Merged

xb-silo: skip xb_query_to_string() unless error is set #137

merged 1 commit into from Jul 31, 2023

Commits on Jul 31, 2023

  1. xb-silo: skip xb_query_to_string() unless error is set 

    If xb_silo_query_with_root_full() is called without a GError, then there
is no need to format the query for a GError that will be discarded.

In GNOME Software, for example, this could be called 70,000 times for a
trivial query via GNOME Shell. Avoiding this saves about 4% of CPU on an
idle system transitioning to Shell search.
    @chergert
    chergert committed Jul 31, 2023
    Copy the full SHA
    ebe3e4d View commit details
    Browse the repository at this point in the history